Handle idx and size unification in wrap_index manually. #5984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@esc Recreation of previous PR with some git history issues. |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
@stuartarchibald Yes, that is right. |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stuartarchibald
added
4 - Waiting on author
Co-authored-by: stuartarchibald <stuartarchibald@users.noreply.github.com>
DrTodd13
added
4 - Waiting on reviewer
stuartarchibald
added
4 - Waiting on author
stuartarchibald
approved these changes
Jun 16, 2021
stuartarchibald
added
5 - Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5442
wrap_index has to compare idx and size and to do that they need to be the same bitwidth. If one is signed and the other unsigned then the old code to unify to the same bitwidth (based on numpy rules) would also switch the type to double. In this PR, we keep the incoming integer types but just extend the bitwidth to be the max of the incoming types. We handle signedness extension correctly as well.