Merged
Conversation
sklam
force-pushed
the
enh/faster_compile
branch
from
54362fa to
3a2b7a4
Compare
Member
Author
|
3a2b7a4 passes everything except flake8 |
Member
Author
|
Latest commit takes 2sec off of 5sec of SROA in some cases |
# Conflicts: # numba/tests/test_debug.py
Contributor
stuartarchibald
left a comment
stuartarchibald
left a comment
There was a problem hiding this comment.
Thanks for the patch @sklam, code changes in general look good, just a few minor things to resolve. Do you recall the issue(s) related to this change, I'd like to check the performance gains. Many Thanks!
stuartarchibald
added
4 - Waiting on author
Co-authored-by: stuartarchibald <stuartarchibald@users.noreply.github.com>
sklam
added
4 - Waiting on reviewer
stuartarchibald
approved these changes
Jun 16, 2021
Contributor
stuartarchibald
left a comment
stuartarchibald
left a comment
There was a problem hiding this comment.
Thanks for the patch and fixes.
stuartarchibald
added
5 - Ready to merge
This was referenced Jun 21, 2021
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIxing several things to get faster compile time.
.list_vars()in SSA.withat all.allocaneeded to cut time spent in SROA pass in LLVM.