Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster compile #6720

Merged
merged 10 commits into from Jun 16, 2021
Merged

Faster compile #6720

merged 10 commits into from Jun 16, 2021

Conversation

sklam
Copy link
Member

@sklam sklam commented Feb 12, 2021

FIxing several things to get faster compile time.

  • a852412 avoids recursion in SSA. Almostly to allow the compile deep CFG.
  • 6e9edbc caches .list_vars() in SSA.
  • 3a2b7a4 stops withlifting pass from wasting cycles on functions without any with at all.
  • 15e6044 and onwards are reducing the number of alloca needed to cut time spent in SROA pass in LLVM.

@sklam
Copy link
Member Author

sklam commented Feb 12, 2021

3a2b7a4 passes everything except flake8

@sklam
Copy link
Member Author

sklam commented Feb 16, 2021

Latest commit takes 2sec off of 5sec of SROA in some cases

@sklam sklam marked this pull request as ready for review June 14, 2021 15:12
# Conflicts:
#	numba/tests/test_debug.py
@stuartarchibald stuartarchibald added this to the Numba 0.54 RC milestone Jun 14, 2021
Copy link
Contributor

@stuartarchibald stuartarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch @sklam, code changes in general look good, just a few minor things to resolve. Do you recall the issue(s) related to this change, I'd like to check the performance gains. Many Thanks!

numba/core/lowering.py Outdated Show resolved Hide resolved
numba/core/lowering.py Outdated Show resolved Hide resolved
numba/core/lowering.py Outdated Show resolved Hide resolved
numba/core/lowering.py Outdated Show resolved Hide resolved
numba/core/lowering.py Outdated Show resolved Hide resolved
numba/core/lowering.py Outdated Show resolved Hide resolved
numba/core/lowering.py Outdated Show resolved Hide resolved
numba/core/lowering.py Outdated Show resolved Hide resolved
numba/core/lowering.py Outdated Show resolved Hide resolved
numba/core/ssa.py Show resolved Hide resolved
@stuartarchibald stuartarchibald added 4 - Waiting on author Waiting for author to respond to review Effort - medium Medium size effort needed and removed 2 - In Progress labels Jun 14, 2021
Co-authored-by: stuartarchibald <stuartarchibald@users.noreply.github.com>
@sklam sklam added 4 - Waiting on reviewer Waiting for reviewer to respond to author and removed 4 - Waiting on author Waiting for author to respond to review labels Jun 15, 2021
Copy link
Contributor

@stuartarchibald stuartarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch and fixes.

@stuartarchibald stuartarchibald added 5 - Ready to merge Review and testing done, is ready to merge and removed 4 - Waiting on reviewer Waiting for reviewer to respond to author labels Jun 16, 2021
@esc esc merged commit 482b332 into numba:master Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to merge Review and testing done, is ready to merge Effort - medium Medium size effort needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants