Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CUDA-specific pipeline #6731

Merged
merged 2 commits into from Feb 19, 2021
Merged

Add CUDA-specific pipeline #6731

merged 2 commits into from Feb 19, 2021

Conversation

gmarkall
Copy link
Member

In preparation for customizing the CUDA compilation pipeline, this PR adds a CUDA pipeline separate from the Nopython pipeline it currently uses. This initial CUDA pipeline is identical to the Nopython pipeline, with two exceptions:

  • It uses the CUDABackend stage instead of the NoPythonBackend stage. The CUDABackend stage populates a compile_result like the NoPythonBackend stage, but doesn't populate it with things that make no sense in CUDA (e.g. objectmode, lifted, etc.).
  • It omits the DumpParforDiagnostics stage.

This needed the NativeLowering stage to be moved out into the pipeline definition instead of being run from within NoPythonBackend.

This is in preparation for the addition of a CUDA-specific pipeline,
that won't use the Nopython mode backend stage.
This is identical to the nopython pipeline, with two exceptions:

- It uses the CUDABackend stage instead of the NoPythonBackend stage.
  The CUDABackend stage populates a compile_result like the
  NoPythonBackend stage, but doesn't populate it with things that make
  no sense in CUDA (e.g. `objectmode`, `lifted`, etc.).
- It omits the DumpParforDiagnostics stage.
@gmarkall
Copy link
Member Author

The fail was only the typeguard issue, so I'm marking this as RfR.

@stuartarchibald stuartarchibald added the Pending BuildFarm For PRs that have been reviewed but pending a push through our buildfarm label Feb 18, 2021
Copy link
Contributor

@stuartarchibald stuartarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch, and for fixing my TODO's :) Nice to see CUDA getting its own pipeline!

@stuartarchibald stuartarchibald added 4 - Waiting on CI Review etc done, waiting for CI to finish and removed 3 - Ready for Review labels Feb 18, 2021
@stuartarchibald
Copy link
Contributor

Buildfarm ID: numba_smoketest_cuda_yaml_14.

@stuartarchibald
Copy link
Contributor

Buildfarm ID: numba_smoketest_cuda_yaml_14.

Passed.

@stuartarchibald stuartarchibald added 5 - Ready to merge Review and testing done, is ready to merge BuildFarm Passed For PRs that have been through the buildfarm and passed and removed 4 - Waiting on CI Review etc done, waiting for CI to finish Pending BuildFarm For PRs that have been reviewed but pending a push through our buildfarm labels Feb 19, 2021
@sklam sklam merged commit 3fd158f into numba:master Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to merge Review and testing done, is ready to merge BuildFarm Passed For PRs that have been through the buildfarm and passed CUDA CUDA related issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants