Add CUDA-specific pipeline #6731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is in preparation for the addition of a CUDA-specific pipeline, that won't use the Nopython mode backend stage.
This is identical to the nopython pipeline, with two exceptions: - It uses the CUDABackend stage instead of the NoPythonBackend stage. The CUDABackend stage populates a compile_result like the NoPythonBackend stage, but doesn't populate it with things that make no sense in CUDA (e.g. `objectmode`, `lifted`, etc.). - It omits the DumpParforDiagnostics stage.
gmarkall
requested review from
esc,
sklam and
stuartarchibald
as code owners
Member
Author
|
The fail was only the typeguard issue, so I'm marking this as RfR. |
stuartarchibald
added
the
Pending BuildFarm
stuartarchibald
approved these changes
Feb 18, 2021
Contributor
stuartarchibald
left a comment
stuartarchibald
left a comment
There was a problem hiding this comment.
Thanks for the patch, and for fixing my TODO's :) Nice to see CUDA getting its own pipeline!
stuartarchibald
added
4 - Waiting on CI
Contributor
|
Buildfarm ID: |
Contributor
Passed. |
stuartarchibald
added
5 - Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for customizing the CUDA compilation pipeline, this PR adds a CUDA pipeline separate from the Nopython pipeline it currently uses. This initial CUDA pipeline is identical to the Nopython pipeline, with two exceptions:
CUDABackendstage instead of theNoPythonBackendstage. TheCUDABackendstage populates acompile_resultlike theNoPythonBackendstage, but doesn't populate it with things that make no sense in CUDA (e.g.objectmode,lifted, etc.).DumpParforDiagnosticsstage.This needed the
NativeLoweringstage to be moved out into the pipeline definition instead of being run from withinNoPythonBackend.