CUDA: Remove NUMBAPRO env var warnings, envvars.py + other small tidy-ups #6844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `NUMBAPRO_*` env vars have been deprecated and ignored since 0.45 - this commit removes the warning about them. Now the warning is gone, the `get_numba_envvar` function serves no purpose above normal environment variables, so the variables that this was used for are converted to normal config variables, and documented. I changed the `VERBOSE_CU_JIT_LOG` variable name to `CUDA_VERBOSE_JIT_LOG` for consistency - I don't believe this needs a deprecation cycle as it's never been public (and is likely unused in general).
The CUDA toolkits supported by Numba at present (9.x onwards) all required CC 3.0 or above, so we should check for CC 3.0 or above as well.
gmarkall
added
2 - In Progress
CUDA
docs/source/reference/envvars.rst
Outdated
|
|
||
| Path of the directory in which the CUDA driver libraries are to be found. | ||
| Normally this should not need to be set as Numba can locate the driver in | ||
| standard locations. However, ths variable can be used if the driver is in a |
There was a problem hiding this comment.
Suggested change
| standard locations. However, ths variable can be used if the driver is in a | |
| standard locations. However, this variable can be used if the driver is in a |
docs/source/reference/envvars.rst
Outdated
|
|
||
| .. envvar:: NUMBA_CUDA_LOG_SIZE | ||
|
|
||
| Buffer size for logs produced by driver API operations. This defaults to 1024 |
There was a problem hiding this comment.
Suggested change
| Buffer size for logs produced by driver API operations. This defaults to 1024 | |
| Buffer size for logs produced by CUDA driver API operations. This defaults to 1024 |
docs/source/reference/envvars.rst
Outdated
|
|
||
| .. envvar:: NUMBA_CUDA_VERBOSE_JIT_LOG | ||
|
|
||
| Whether the driver should produce verbose log messages. Defaults to 1, |
There was a problem hiding this comment.
Suggested change
| Whether the driver should produce verbose log messages. Defaults to 1, | |
| Whether the CUDA driver should produce verbose log messages. Defaults to 1, |
stuartarchibald
added
4 - Waiting on author
|
@stuartarchibald Many thanks for the review - documentation suggestions applied, and other questions responded to. |
gmarkall
added
4 - Waiting on reviewer
stuartarchibald
previously approved these changes
Mar 22, 2021
stuartarchibald
added
4 - Waiting on CI
|
Buildfarm ID: |
Passed. |
stuartarchibald
added
5 - Ready to merge
|
@gmarkall , there's a conflict |
|
Conflicts now resolved. |
Thanks @gmarkall, looks good. |
stuartarchibald
approved these changes
Mar 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
NUMBAPRO_*env vars have been deprecated and ignored since 0.45 - this PR removes the warning about them. Now the warning is gone, theget_numba_envvarfunction serves no purpose above normal environment variables, so the variables that this was used for are converted to normal config variables, and documented.I changed the
VERBOSE_CU_JIT_LOGvariable name toCUDA_VERBOSE_JIT_LOGfor consistency - I don't believe this needs a deprecation cycle as it's never been public (and is likely unused in general).There are a couple of other small tidy-ups bundled in this PR related to the NumbaPro name, a stale link, and a correction to the check for minumum supported compute capability.