Skip to content

PR 6096 continued #6854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Mar 26, 2021
Merged

PR 6096 continued #6854

merged 10 commits into from
Mar 26, 2021

Conversation

stuartarchibald
Copy link
Contributor

@stuartarchibald stuartarchibald commented Mar 23, 2021 •
edited
Loading

Continues #6096...

  • Adds public CI support
  • Updates conda recipes
  • Removes Python 3 version guards
  • Removes references/support for TBB < 2021.

@stuartarchibald
Use Numba channel.
7d41603 
As title.
@stuartarchibald
Clean up.
9bebb9c 
* Python < 3 code removed.
* Code relating to old ABI tbb removed, version guards updated.
@stuartarchibald
Force tbb 2021
11836a9 
As title
@stuartarchibald
Sort out tbb for windows
2c3c759
@stuartarchibald stuartarchibald added this to the Numba 0.54 RC milestone Mar 24, 2021
@stuartarchibald
Copy link
Contributor Author

@Hardcode84 Are you happy with the contents of this patch? It's essentially a reduced version of #6096, TBB minimum version is raised to 2021 version 1.

@Hardcode84
Copy link

LGTM

@stuartarchibald
Copy link
Contributor Author

LGTM

@Hardcode84 Thanks for checking.

@stuartarchibald
Copy link
Contributor Author

Buildfarm ID: numba_smoketest_cpu_yaml_12.

@stuartarchibald
Copy link
Contributor Author

Buildfarm ID: numba_smoketest_cpu_yaml_12.

This passed.

@stuartarchibald stuartarchibald added the Effort - medium Medium size effort needed label Mar 26, 2021
sklam
sklam approved these changes Mar 26, 2021
View reviewed changes
Copy link
Member

@sklam sklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sklam sklam added 5 - Ready to merge Review and testing done, is ready to merge BuildFarm Passed For PRs that have been through the buildfarm and passed and removed 3 - Ready for Review labels Mar 26, 2021
@sklam sklam merged commit 52e52e7 into numba:master Mar 26, 2021
@stuartarchibald stuartarchibald mentioned this pull request Apr 7, 2021
Closed
2 tasks
@stuartarchibald stuartarchibald mentioned this pull request Apr 23, 2021
Closed
2 tasks
@stuartarchibald stuartarchibald mentioned this pull request Jun 18, 2021
Closed
@stuartarchibald stuartarchibald mentioned this pull request Nov 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sklam sklam sklam approved these changes

@esc esc Awaiting requested review from esc

Assignees
No one assigned
Labels
5 - Ready to merge Review and testing done, is ready to merge BuildFarm Passed For PRs that have been through the buildfarm and passed Effort - medium Medium size effort needed
Projects
None yet
Milestone
Numba 0.54 RC
Development

Successfully merging this pull request may close these issues.
3 participants
@stuartarchibald @Hardcode84 @sklam