Skip to content

Force text-align:left when using Annotate #6871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 29, 2021
Merged

Force text-align:left when using Annotate #6871

merged 2 commits into from
Mar 29, 2021

Conversation

guilhermeleobas
Copy link
Contributor

@guilhermeleobas guilhermeleobas commented Mar 26, 2021 •
edited
Loading

This is a simple fix for #4064

Before:
image

Result after fix:
image

@guilhermeleobas guilhermeleobas marked this pull request as draft March 26, 2021 21:56
@guilhermeleobas guilhermeleobas marked this pull request as ready for review March 26, 2021 22:08
@sklam sklam added 3 - Ready for Review Effort - short Short size effort needed labels Mar 26, 2021
stuartarchibald
stuartarchibald approved these changes Mar 29, 2021
View reviewed changes
Copy link
Contributor

@stuartarchibald stuartarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch. I verified the change manually in jupyter-lab.

@stuartarchibald stuartarchibald added 5 - Ready to merge Review and testing done, is ready to merge and removed 3 - Ready for Review labels Mar 29, 2021
@stuartarchibald stuartarchibald added this to the Numba 0.54 RC milestone Mar 29, 2021
@sklam sklam merged commit b5bd9c6 into numba:master Mar 29, 2021
@guilhermeleobas guilhermeleobas deleted the fix_annotate branch March 29, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartarchibald stuartarchibald stuartarchibald approved these changes

@esc esc Awaiting requested review from esc

@sklam sklam Awaiting requested review from sklam

Assignees
No one assigned
Labels
5 - Ready to merge Review and testing done, is ready to merge Effort - short Short size effort needed
Projects
None yet
Milestone
Numba 0.54 RC
Development

Successfully merging this pull request may close these issues.
3 participants
@guilhermeleobas @stuartarchibald @sklam