Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc for recent target extension features #6877

Merged
merged 3 commits into from Apr 9, 2021

Conversation

sklam
Copy link
Member

@sklam sklam commented Mar 30, 2021

  • Add docs on compiler flag inheritance

@sklam sklam force-pushed the misc/doc_target_extension branch from 0d5585e to 6c1088b Compare March 30, 2021 17:40
Copy link
Contributor

@stuartarchibald stuartarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these docs, a few minor things to look at else looks good.

docs/source/developer/target_extension.rst Outdated Show resolved Hide resolved
docs/source/developer/target_extension.rst Outdated Show resolved Hide resolved
docs/source/developer/target_extension.rst Outdated Show resolved Hide resolved
docs/source/developer/target_extension.rst Outdated Show resolved Hide resolved
docs/source/developer/target_extension.rst Outdated Show resolved Hide resolved
@stuartarchibald stuartarchibald added this to the Numba 0.54 RC milestone Mar 31, 2021
Co-authored-by: stuartarchibald <stuartarchibald@users.noreply.github.com>
@sklam sklam added 4 - Waiting on reviewer Waiting for reviewer to respond to author and removed 2 - In Progress labels Mar 31, 2021
@sklam
Copy link
Member Author

sklam commented Mar 31, 2021

I was planning to add more documentation but since this is reviewed. I will keep it short and add more in a new PR.

Copy link
Contributor

@stuartarchibald stuartarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for patch and fixes. I've added dealing with the "TODO"s to #6908

@stuartarchibald
Copy link
Contributor

@stuartarchibald stuartarchibald added 5 - Ready to merge Review and testing done, is ready to merge Effort - short Short size effort needed and removed 4 - Waiting on reviewer Waiting for reviewer to respond to author labels Apr 9, 2021
@sklam sklam merged commit a5fbd08 into numba:master Apr 9, 2021
@sklam sklam deleted the misc/doc_target_extension branch April 9, 2021 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to merge Review and testing done, is ready to merge doc Effort - short Short size effort needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants