Add doc for recent target extension features#6877
Merged
sklam merged 3 commits intonumba:masterfrom Apr 9, 2021
Merged
Conversation
Member
sklam
commented
Mar 30, 2021
sklam
commented
- Add docs on compiler flag inheritance
sklam
force-pushed
the
misc/doc_target_extension
branch
from
0d5585e to
6c1088b
Compare
4 tasks
Contributor
stuartarchibald
left a comment
stuartarchibald
left a comment
There was a problem hiding this comment.
Thanks for adding these docs, a few minor things to look at else looks good.
Co-authored-by: stuartarchibald <stuartarchibald@users.noreply.github.com>
sklam
added
4 - Waiting on reviewer
Member
Author
|
I was planning to add more documentation but since this is reviewed. I will keep it short and add more in a new PR. |
stuartarchibald
approved these changes
Apr 9, 2021
Contributor
stuartarchibald
left a comment
stuartarchibald
left a comment
There was a problem hiding this comment.
Thanks for patch and fixes. I've added dealing with the "TODO"s to #6908
Contributor
|
PR doc build is here: https://numba--6877.org.readthedocs.build/en/6877/developer/target_extension.html |
stuartarchibald
added
5 - Ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.