Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #6884 #6890

Merged
merged 1 commit into from Apr 6, 2021
Merged

fixes #6884 #6890

merged 1 commit into from Apr 6, 2021

Conversation

rawwar
Copy link
Contributor

@rawwar rawwar commented Apr 2, 2021

fixes #6884

I checked test_matmul the boundary conditions check is correct. only the documentation has the typo

Copy link
Member

@gmarkall gmarkall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does make an improvement by fixing something that is clearly an error the example, so this should be merged.

However, I think the example would be more helpful if it were actually executable - at the moment I don't know for certain that the example is correct even with this change. Converting it to a tested example like those in https://github.com/numba/numba/tree/master/numba/cuda/tests/doc_examples would be a further improvement.

@gmarkall gmarkall added CUDA CUDA related issue/PR 5 - Ready to merge Review and testing done, is ready to merge and removed 5 - Ready to merge Review and testing done, is ready to merge CUDA CUDA related issue/PR labels Apr 6, 2021
@gmarkall gmarkall added this to the Numba 0.54 RC milestone Apr 6, 2021
@gmarkall gmarkall added the 5 - Ready to merge Review and testing done, is ready to merge label Apr 6, 2021
@gmarkall
Copy link
Member

gmarkall commented Apr 6, 2021

Forgot to say - thanks for the fix!

Copy link
Contributor

@stuartarchibald stuartarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch @rawwar , thanks for reviewing @gmarkall .

@sklam sklam merged commit 20d1261 into numba:master Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to merge Review and testing done, is ready to merge CUDA CUDA related issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CUDA matrix multiplication example is probably wrong
4 participants