fixes #6884 #6890
Merged
fixes #6884 #6890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarkall
approved these changes
Apr 6, 2021
Member
gmarkall
left a comment
gmarkall
left a comment
There was a problem hiding this comment.
This does make an improvement by fixing something that is clearly an error the example, so this should be merged.
However, I think the example would be more helpful if it were actually executable - at the moment I don't know for certain that the example is correct even with this change. Converting it to a tested example like those in https://github.com/numba/numba/tree/master/numba/cuda/tests/doc_examples would be a further improvement.
gmarkall
added
CUDA
Member
|
Forgot to say - thanks for the fix! |
stuartarchibald
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6884
I checked
test_matmulthe boundary conditions check is correct. only the documentation has the typo