Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add runtests option to gitdiff on the common ancestor #6913

Merged
merged 3 commits into from Apr 13, 2021

Conversation

sklam
Copy link
Member

@sklam sklam commented Apr 9, 2021

Example:

python -m numba.runtests -g=ancestor

This allows us to test PR HEAD against its first splitting point from main branch. Useful for testing just the changes in the PR instead of including all new additions to the mainline.

Copy link
Contributor

@stuartarchibald stuartarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch, this will be useful. One minor comment to resolve else looks good. I've also tested this manually.

Comment on lines 133 to 134
with self.assertRaises(subprocess.CalledProcessError):
self.get_testsuite_listing(['-g=ancest'])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds noise to the test output as the error streams aren't captured/redirected?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, i'll sink it to devnull

@stuartarchibald stuartarchibald added 4 - Waiting on author Waiting for author to respond to review Effort - short Short size effort needed and removed 3 - Ready for Review labels Apr 12, 2021
@stuartarchibald stuartarchibald added this to the Numba 0.54 RC milestone Apr 12, 2021
Copy link
Contributor

@stuartarchibald stuartarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch and fixes.

@stuartarchibald stuartarchibald added 5 - Ready to merge Review and testing done, is ready to merge and removed 4 - Waiting on author Waiting for author to respond to review labels Apr 13, 2021
@sklam sklam merged commit 7c18f65 into numba:master Apr 13, 2021
@sklam sklam deleted the enh/gitdiffancestor branch April 13, 2021 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to merge Review and testing done, is ready to merge Effort - short Short size effort needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants