Add runtests option to gitdiff on the common ancestor #6913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stuartarchibald
left a comment
stuartarchibald
left a comment
There was a problem hiding this comment.
Thanks for the patch, this will be useful. One minor comment to resolve else looks good. I've also tested this manually.
numba/tests/test_runtests.py
Outdated
Comment on lines
133
to
134
| with self.assertRaises(subprocess.CalledProcessError): | ||
| self.get_testsuite_listing(['-g=ancest']) |
Contributor
There was a problem hiding this comment.
This adds noise to the test output as the error streams aren't captured/redirected?
Member
Author
There was a problem hiding this comment.
ok, i'll sink it to devnull
stuartarchibald
added
4 - Waiting on author
stuartarchibald
approved these changes
Apr 13, 2021
Contributor
stuartarchibald
left a comment
stuartarchibald
left a comment
There was a problem hiding this comment.
Thanks for the patch and fixes.
stuartarchibald
added
5 - Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example:
This allows us to test PR HEAD against its first splitting point from main branch. Useful for testing just the changes in the PR instead of including all new additions to the mainline.