Skip to content

Start section on commonly encounted unsupported parfors code. #6918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 12, 2021
Merged

Start section on commonly encounted unsupported parfors code. #6918

merged 2 commits into from
Apr 12, 2021

Conversation

stuartarchibald
Copy link
Contributor

As title. This covers a couple of commonly reported problems.

@stuartarchibald
Start section on commonly encounted unsupported parfors code.
a4fca52 
As title. This covers a couple of commonly reported problems.
@stuartarchibald stuartarchibald mentioned this pull request Apr 12, 2021
Closed
sklam
sklam reviewed Apr 12, 2021
View reviewed changes
Copy link
Member

@sklam sklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch! I think adding a title sentence for each example can allow users to read it faster.

@sklam sklam added 4 - Waiting on author Waiting for author to respond to review and removed 3 - Ready for Review labels Apr 12, 2021
sklam
sklam approved these changes Apr 12, 2021
View reviewed changes
Copy link
Member

@sklam sklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sklam sklam added 4 - Waiting on CI Review etc done, waiting for CI to finish and removed 4 - Waiting on author Waiting for author to respond to review labels Apr 12, 2021
@stuartarchibald stuartarchibald added 5 - Ready to merge Review and testing done, is ready to merge and removed 4 - Waiting on CI Review etc done, waiting for CI to finish labels Apr 12, 2021
@stuartarchibald
Copy link
Contributor Author

CI passed. Thanks for the review @sklam.

@stuartarchibald stuartarchibald added this to the Numba 0.54 RC milestone Apr 12, 2021
@sklam sklam merged commit 835e56c into numba:master Apr 12, 2021
@stuartarchibald stuartarchibald mentioned this pull request Jun 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sklam sklam sklam approved these changes

@esc esc Awaiting requested review from esc

Assignees
No one assigned
Labels
5 - Ready to merge Review and testing done, is ready to merge Effort - short Short size effort needed
Projects
None yet
Milestone
Numba 0.54 RC
Development

Successfully merging this pull request may close these issues.
2 participants
@stuartarchibald @sklam