Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CUDA @intrinsic use #6971

Merged
merged 1 commit into from
Apr 23, 2021
Merged

Fix CUDA @intrinsic use #6971

merged 1 commit into from
Apr 23, 2021

Conversation

stuartarchibald
Copy link
Contributor

As title. The CUDA dispatcher needs a target description as the
@intrinsic function templates query it.

Fixes #6970

@stuartarchibald
Fix CUDA @intrinsic use
e34481b 
As title. The CUDA dispatcher needs a target description as the
`@intrinsic` function templates query it.

Fixes numba#6970
@stuartarchibald stuartarchibald added this to the Numba 0.54 RC milestone Apr 23, 2021
@stuartarchibald
Copy link
Contributor Author

@sklam this fixes mainline for the CUDA target.

@stuartarchibald
Copy link
Contributor Author

Also CC @gmarkall as code owner.

@stuartarchibald
Copy link
Contributor Author

Buildfarm ID: numba_smoketest_cuda_yaml_50.

gmarkall
gmarkall approved these changes Apr 23, 2021
View reviewed changes
Copy link
Member

@gmarkall gmarkall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the CUDA tests locally for me.

@sklam
Copy link
Member

sklam commented Apr 23, 2021

Buildfarm passed

@sklam sklam added the BuildFarm Passed For PRs that have been through the buildfarm and passed label Apr 23, 2021
sklam
sklam approved these changes Apr 23, 2021
View reviewed changes
Copy link
Member

@sklam sklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch!

@sklam sklam added 5 - Ready to merge Review and testing done, is ready to merge and removed 3 - Ready for Review labels Apr 23, 2021
@sklam
Copy link
Member

sklam commented Apr 23, 2021

The CI failure will be fixed by #6966

@sklam sklam merged commit 9d9aef8 into numba:master Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmarkall gmarkall gmarkall approved these changes

@sklam sklam sklam approved these changes

Assignees
No one assigned
Labels
5 - Ready to merge Review and testing done, is ready to merge BuildFarm Passed For PRs that have been through the buildfarm and passed CUDA CUDA related issue/PR
Projects
None yet
Milestone
Numba 0.54 RC
Development

Successfully merging this pull request may close these issues.

@intrinsic not working with CUDA
3 participants
@stuartarchibald @sklam @gmarkall