Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github action to mark issues as stale #7040

Merged
merged 3 commits into from May 27, 2021

Conversation

gmarkall
Copy link
Member

This uses the stale action.

The intended configuration is:

  • At 1:30 every day, any issues that have been inactive for 30 days are:
    • Labelled stale, and
    • Have a comment posted explaining why they're stale and requesting an update or that the issue be closed.
  • Labels pertaining to long-term items, feature requests, and good first / second issues do not get marked.
  • Stale issues are never closed.

This uses the [stale action](https://github.com/actions/stale).

The intended configuration is:

- At 1:30 every day, any issues that have been inactive for 30 days are:
  - Labelled stale, and
  - Have a comment posted explaining why they're stale and requesting an
    update or that the issue be closed.
- Labels pertaining to long-term items, feature requests, and good first
  / second issues do not get marked.
- Stale issues are never closed.
@esc
Copy link
Member

esc commented May 18, 2021

@gmarkall thank you for looking into this. FWIW: some time ago we had attempted something similar:

#6225

IIRC we encountered some serious issues related to filtering of labels and selecting issues and PRs that are never tobe marked as stale. Further IIRC this was related to bugs within Github that seemed to only manifest when the number of labels was large (like in the Numba repo). Even further IIRC I reached out to Github about this issue, they actually responded several times mentioning that they could reproduce it and were working on it but have gone radio-silent since then.

@gmarkall
Copy link
Member Author

@esc thanks for the comments - #6225 looks like it's using something different - the Github Stale app based on Probot seems to be distinct from the Stale action that this uses. Do you have any idea if the bugs in Github were generic related to labels, or were they problems with that app?

(FWIW, I note that other projects such as the RAPIDS ones seem to be able to make use of the Stale action on which this PR is based, but I've no direct experience managing / running that)

@esc
Copy link
Member

esc commented May 18, 2021

Here are some screenshots from my interactions with GitHub, I'v reached out again today. Sorry that the order is a bit messed up, please use the dates of each message to accurately reconstruct the flow (but all the messages are there).

Screen Shot 2021-05-18 at 17 52 41

Screen Shot 2021-05-18 at 17 53 09

Screen Shot 2021-05-18 at 17 53 19

Copy link
Member

@sklam sklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok to merge it today so we can test it.

sklam
sklam previously approved these changes May 26, 2021
@esc
Copy link
Member

esc commented May 26, 2021

Would add:

  • 'bug - documentation incorrect'
  • 'bug - numerically incorrect'
  • 'caching'
  • 'discussion'
  • 'doc
  • 'installation'
  • 'jitclass'
  • 'llvm'
  • 'question'

And what about the ones with a numerical prefix? Like '0 - Backlog'

Copy link
Member

@esc esc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's get this in!

@esc esc added 5 - Ready to merge Review and testing done, is ready to merge and removed 3 - Ready for Review labels May 27, 2021
@stuartarchibald stuartarchibald added the Effort - medium Medium size effort needed label May 27, 2021
@stuartarchibald stuartarchibald added this to the Numba 0.54 RC milestone May 27, 2021
@sklam sklam merged commit cbb4301 into numba:master May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to merge Review and testing done, is ready to merge Effort - medium Medium size effort needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants