Add support for axis keyword argument to np.argmin() #7129
Conversation
| min_idx = 0 | ||
| if _is_nat(min_value): | ||
| return min_idx | ||
| @register_jitable |
There was a problem hiding this comment.
This function's code is unchanged, it's simply moved to the top-level whereas previously it was internal to array_argmin.
| min_idx = idx | ||
| idx += 1 | ||
| return min_idx | ||
| @register_jitable |
There was a problem hiding this comment.
This function's code is unchanged, it's simply moved to the top-level whereas previously it was internal to array_argmin.
|
|
||
| @register_jitable |
There was a problem hiding this comment.
This function's code is unchanged, it's simply moved to the top-level whereas previously it was internal to array_argmin.
| @@ -771,6 +786,50 @@ def array_argmax_impl_generic(arry): | |||
| return max_idx | |||
|
|
|||
|
|
|||
| def build_argmax_or_argmin_with_axis_impl(arr, axis, flatten_impl): | |||
There was a problem hiding this comment.
This function's code is unchanged, it's simply moved to the top-level (whereas previously it was internal to array_argmax) so it can be used by both argmin and argmax implementations.
| @@ -785,42 +844,9 @@ def array_argmax(arr, axis=None): | |||
| def array_argmax_impl(arr, axis=None): | |||
| return flatten_impl(arr) | |||
| else: | |||
| _check_is_integer(axis, "axis") | |||
There was a problem hiding this comment.
This code now lives in build_argmax_or_argmin_with_axis_impl, unchanged otherwise.
itamarst
changed the title
stuartarchibald
added
3 - Ready for Review
Effort - medium
| min_idx = 0 | ||
| if _is_nat(min_value): | ||
| return min_idx | ||
| @register_jitable |
| min_idx = idx | ||
| idx += 1 | ||
| return min_idx | ||
| @register_jitable |
|
|
||
| @register_jitable |
| @@ -771,6 +786,50 @@ def array_argmax_impl_generic(arry): | |||
| return max_idx | |||
|
|
|||
|
|
|||
| def build_argmax_or_argmin_with_axis_impl(arr, axis, flatten_impl): | |||
| @@ -785,42 +844,9 @@ def array_argmax(arr, axis=None): | |||
| def array_argmax_impl(arr, axis=None): | |||
| return flatten_impl(arr) | |||
| else: | |||
| _check_is_integer(axis, "axis") | |||
stuartarchibald
added
5 - Ready to merge
Note to reviewers: this PR is actually much simpler than the line count would suggest, for the most part it's just very minor refactoring (refactoring internal functions so they're top-level functions) and reuses a lot of existing code from #6928.
I have added inline comments noting where code is unchanged and merely moved.