Split parfors tests #7160
Merged
Split parfors tests #7160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartarchibald
force-pushed
the
wip/split_parfors_tests
branch
from
2c73105
to
734e908
Compare
As title
stuartarchibald
force-pushed
the
wip/split_parfors_tests
branch
from
734e908
to
dd72e3b
Compare
As title
As title
sklam
reviewed
Jun 29, 2021
numba/tests/test_parfors.py
Outdated
| class TestParforsBase(TestCase): | ||
|
|
||
| @needs_subprocess | ||
| class TestParforsBase(TestCase, MemoryLeakMixin): |
There was a problem hiding this comment.
Suggested change
| class TestParforsBase(TestCase, MemoryLeakMixin): | |
| class TestParforsBase(MemoryLeakMixin, TestCase): |
mixin class goes first; earlier in the MRO
sklam
reviewed
Jun 29, 2021
numba/tests/test_parfors.py
Outdated
| @@ -44,6 +46,83 @@ | |||
| import cmath | |||
| import unittest | |||
|
|
|||
| # NOTE: Each parfors test class is run in separate subprocess, this to reduce | |||
There was a problem hiding this comment.
Suggested change
| # NOTE: Each parfors test class is run in separate subprocess, this to reduce | |
| # NOTE: Each parfors test class is run in separate subprocess, this is to reduce |
numba/tests/test_parfors.py
Outdated
| status = subprocess.run(cmd, stdout=subprocess.PIPE, | ||
| stderr=subprocess.PIPE, timeout=self._TIMEOUT, | ||
| env=env_copy, universal_newlines=True) | ||
| self.assertEqual(status.returncode, 0) |
There was a problem hiding this comment.
Suggested change
| self.assertEqual(status.returncode, 0) | |
| self.assertEqual(status.returncode, 0, msg=status.stderr) |
so that we know what tests are failing.
stuartarchibald
added
4 - Waiting on reviewer
sklam
reviewed
Jun 29, 2021
Co-authored-by: Siu Kwan Lam <1929845+sklam@users.noreply.github.com>
sklam
added
5 - Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work on splitting up the parfors test suite.