CUDA: Fix test_pinned on Jetson #7190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinning memory with `cuMemHostRegister()` now appears to be supported, but only for memory regions < 4MB. This commit fixes test_pinned by only attempting to pin a 2MB array on ARM.
|
Making this ready for review as it is a complete fix in itself, and I won't have time to look into whether I can reproduce the other (separate) issue. |
stuartarchibald
changed the title
Comment on lines
+24
to
+26
| count = 262144 # 2MB | ||
| else: | ||
| count = 2097152 # 16MB |
There was a problem hiding this comment.
Assumes an 8 byte intp? Given a 4 byte intp would lead to a smaller allocation size, I think this is still fine.
There was a problem hiding this comment.
Indeed. All systems that support CUDA are 64-bit anyway.
stuartarchibald
approved these changes
Jul 9, 2021
stuartarchibald
added
4 - Waiting on CI
|
BFID |
sklam
added
Pending BuildFarm
|
BF passed, but i thk we still need a Jetson test(?) |
That would be ideal, but it's up to you :-) |
|
I actually don't have a Xavier to make it work. Since I'm not seeing any new failures, i'm marking this as ready. |
sklam
added
5 - Ready to merge
|
Does this fail on a Jetson Nano? (I don't have one to test) |
sklam
added a commit
to sklam/numba
that referenced
this pull request
Aug 4, 2021
CUDA: Fix test_pinned on Jetson
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pinning memory with
cuMemHostRegister()now appears to be supported, but only for memory regions < 4MB. This commit fixes test_pinned by only attempting to pin a 2MB array on ARM.Marking as draft for now as there is another test case in Issue #2849 that is failing that I need to check.