Prevent mutation of arrays in global tuples. #7307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As title. Fixes numba#7120
stuartarchibald
added
3 - Ready for Review
Effort - short
esc
previously approved these changes
Nov 22, 2021
|
@stuartarchibald there are still some conflicts to be resolved so I'll give it the final approval when those have been resolved. |
esc
added
4 - Waiting on author
Conflicts: numba/core/typing/arraydecl.py
|
esc
approved these changes
Nov 23, 2021
|
@stuartarchibald thank you for the patch! |
esc
added
5 - Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.
Fixes #7120