Add version support information table to docs. #7833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a table to the docs that shows which versions of Numba's dependencies were tested and known to work against which version of Numba. It also updates the `first_rc_checklist.md` issue template to ensure that this information is provided along side future releases.
stuartarchibald
added
3 - Ready for Review
Effort - medium
sklam
reviewed
Feb 17, 2022
| @@ -0,0 +1,37 @@ | |||
| .. _support_info: | |||
There was a problem hiding this comment.
I think this page should be referenced in the installation doc: https://numba--7833.org.readthedocs.build/en/7833/user/installing.html
There was a problem hiding this comment.
I would actual raise the argument, that the version support information table, should go alongside our canonical reference for the other dependencies, here:
https://numba.readthedocs.io/en/stable/user/installing.html#dependency-list
This would mean, all dependency information is in a single place and can percolate into the various places (setup.py et.c..) from there. How does that sound?
There was a problem hiding this comment.
867223f makes this move, I'm happy either way, am just glad this reference now exists!
sklam
added
4 - Waiting on author
Merged
stuartarchibald
added
4 - Waiting on reviewer
sklam
added
5 - Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a table to the docs that shows which versions of Numba's
dependencies were tested and known to work against which version of
Numba. It also updates the
first_rc_checklist.mdissue templateto ensure that this information is provided along side future
releases.