Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the release template to include updating the version table. #8198

Merged
merged 2 commits into from Jun 30, 2022
Merged

Update the release template to include updating the version table. #8198

merged 2 commits into from Jun 30, 2022

Conversation

stuartarchibald
Copy link
Contributor

As title, to ensure that the final release date is included in the
release branch documentation.

@stuartarchibald
Update the release template to include updating the version table.
24f7385 
As title, to ensure that the final release date is included in the
release branch documentation.
@stuartarchibald stuartarchibald mentioned this pull request Jun 27, 2022
Merged
@stuartarchibald stuartarchibald marked this pull request as ready for review June 27, 2022 12:09
@stuartarchibald stuartarchibald added the Effort - short Short size effort needed label Jun 27, 2022
@stuartarchibald stuartarchibald added this to the Numba 0.56 RC milestone Jun 27, 2022
@esc
Copy link
Member

esc commented Jun 27, 2022

@stuartarchibald I think the cherry-pick should go from releaseX.Y branch to main that way we can release first w/o needing to merge something to main first. What do you think?

@stuartarchibald
Copy link
Contributor Author

@stuartarchibald I think the cherry-pick should go from releaseX.Y branch to main that way we can release first w/o needing to merge something to main first. What do you think?

I don't mind, but either way I think both have to be specified else they get forgotten, cf. #8187.

@esc
Copy link
Member

esc commented Jun 28, 2022

@stuartarchibald I think the cherry-pick should go from releaseX.Y branch to main that way we can release first w/o needing to merge something to main first. What do you think?

I don't mind, but either way I think both have to be specified else they get forgotten, cf. #8187.

I think I would prefer to make the commit on the release branch first and then cherry-pick to main.

esc
esc requested changes Jun 28, 2022
View reviewed changes
Copy link
Member

@esc esc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requesting changes as indicated by: #8198 (comment)

@esc esc mentioned this pull request Jun 29, 2022
Closed
25 tasks
@stuartarchibald
Address review comments.
5801673 
Swap the addressed branches around for targeting version support
table update.
@stuartarchibald
Copy link
Contributor Author

requesting changes as indicated by: #8198 (comment)

Addressed in 5801673.

@stuartarchibald stuartarchibald added 4 - Waiting on reviewer Waiting for reviewer to respond to author and removed 3 - Ready for Review labels Jun 29, 2022
@esc esc added 5 - Ready to merge Review and testing done, is ready to merge and removed 4 - Waiting on reviewer Waiting for reviewer to respond to author labels Jun 29, 2022
@sklam sklam merged commit c852edc into numba:main Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esc esc esc approved these changes

@sklam sklam Awaiting requested review from sklam

Assignees

@esc esc

Labels
5 - Ready to merge Review and testing done, is ready to merge Effort - short Short size effort needed
Projects
@esc's tracker
Archived in project
Milestone
Numba 0.57 RC
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stuartarchibald @esc @sklam