Migrate linear algebra functions from glue_lowering#8256
Merged
Conversation
sklam
reviewed
Jul 21, 2022
Change functions in `linalg` module using `glue_lowering` to new `overload` annotation.
sklam
added
4 - Waiting on author
Replace assertions for unreachable code into exceptions
Add performance warnings about non-contiguous arrays
apmasell
added
3 - Ready for Review
and removed
4 - Waiting on author
sklam
added
5 - Ready to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change functions in
linalgmodule usingglue_loweringto newoverloadannotation.