Repository navigation
Commit 0742c85
committed
Don't automatically show warnings as soon as they're made
fixes #1135
Previously, the warning message pop up was shown as soon as any warning
was created.
The only way for this to happen when you don't have an input focused is
as a result of submitting the part.
It's very easy for the warning box to overlap the part feedback or
other parts of the prompt. In gap-fill parts, there can be so many boxes
that almost the entire part is covered.
This changes the logic so that warnings are only shown when you focus
an input element.
"Invalid input" warnings are usually repeated as "fail" feedback
messages, so the student will still see why their answer was invalid
after submitting.1 parent 7a72533 commit 0742c85
2 files changed
Lines changed: 1 addition & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1013 | 1013 | | |
1014 | 1014 | | |
1015 | 1015 | | |
| 1016 | + | |
1016 | 1017 | | |
1017 | 1018 | | |
1018 | 1019 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
674 | 674 | | |
675 | 675 | | |
676 | 676 | | |
677 | | - | |
678 | 677 | | |
679 | 678 | | |
680 | 679 | | |
| |||
683 | 682 | | |
684 | 683 | | |
685 | 684 | | |
686 | | - | |
687 | | - | |
688 | | - | |
689 | 685 | | |
690 | 686 | | |
691 | 687 | | |
| |||
0 commit comments