Skip to content

Commit f80467f

Browse files
committed
always show part feedback messages when there's only one part
1 parent d6a8986 commit f80467f

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

themes/default/files/scripts/knockout-handlers.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -304,9 +304,11 @@ Numbas.queueScript('knockout-handlers',['display-util', 'display-base', 'answer-
304304
Knockout.bindingHandlers.open = {
305305
init: function(element, valueAccessor) {
306306
const value = valueAccessor();
307-
element.addEventListener('toggle', function(e) {
308-
value(element.open);
309-
});
307+
if(typeof value == 'function') {
308+
element.addEventListener('toggle', function(e) {
309+
value(element.open);
310+
});
311+
}
310312
},
311313

312314
update: function(element, valueAccessor) {

themes/default/templates/xslt/part.xslt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@
5858
</div>
5959
<small class="answered-state" data-bind="html: scoreFeedback.answeredString"></small>
6060
</div>
61-
<details class="feedbackMessages" role="log" aria-live="polite" aria-atomic="true" data-bind="pulse: scoreFeedback.update, open: feedbackShown" localise-data-jme-context-description="part.feedback">
62-
<summary data-bind="text: feedbackToggleText"></summary>
61+
<details class="feedbackMessages" role="log" aria-live="polite" aria-atomic="true" data-bind="pulse: scoreFeedback.update, open: feedbackShown() || !isNotOnlyPart()" localise-data-jme-context-description="part.feedback">
62+
<summary data-bind="text: feedbackToggleText, visible: isNotOnlyPart"></summary>
6363
<p class="out-of-date-message" data-bind="visible: isDirty"><localise>part.feedback out of date</localise></p>
6464
<p class="sr-only" data-bind="visible: isNotOnlyPart, text: feedback_title"></p>
6565
<ol data-bind="visible: shownFeedbackMessages().length, foreach: shownFeedbackMessages">

0 commit comments

Comments
 (0)