Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Results page: make it more obvious that questions can be clicked on to review #519

Closed
christianp opened this issue Jan 9, 2018 · 7 comments

Comments

Projects
None yet
5 participants
@christianp
Copy link
Member

commented Jan 9, 2018

Currently, the question results table in the default theme looks like this:
screen shot 2018-01-09 at 08 30 23
When you hover over a row, it's highlighted and you get a pointer:
screen shot 2018-01-09 at 08 29 36

Parthasarati Dileepan didn't think this was obvious enough - unless you mouse over the rows, it looks static.

Possible ways of making it more obviously clickable:

  • make the question number a link, so it gets the link colour. I don't think that makes enough of a difference.
  • Add another column with a button labelled "review"

The results table is generated by themes/default/templates/result.html

@prakharcipher

This comment has been minimized.

Copy link

commented Jan 11, 2018

I'd like to pick up this issue.

@reddysridhar53

This comment has been minimized.

Copy link

commented Jan 15, 2018

Can I work on this?

@donutsteele

This comment has been minimized.

Copy link

commented Oct 27, 2018

Is this issue still available to work on? I would like to give it a shot

@christianp

This comment has been minimized.

Copy link
Member Author

commented Oct 29, 2018

@donutsteele yes, it's still open

@kjschmidt913

This comment has been minimized.

Copy link

commented Jan 10, 2019

I see this is still open- is anyone working on it or could I?

@christianp

This comment has been minimized.

Copy link
Member Author

commented Jan 10, 2019

@kjschmidt913 thanks for offering - go ahead. Please have a look at our guidelines on contributing to Numbas first, and make a pull request when you've got something we can look at.

@kjschmidt913

This comment has been minimized.

Copy link

commented Jan 10, 2019

@christianp great! Will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.