Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to not show numberentry fraction input hint. #526

Closed
christianp opened this issue Feb 20, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@christianp
Copy link
Member

commented Feb 20, 2018

There's an option showPrecisionHint for when there's a precision restriction. It should also be possible to ask for the fraction input hint not to be displayed.
Requested by Johan Maertens.

To do this:

  • add another option showFractionHint in runtime/scripts/part/numberentry.js, basically copying the code for showPrecisionHint.
  • do the same in themes/default/files/scripts/parts/numberentry-display.js
  • use the setting to decide whether to show the hint in themes/default/templates/xslt/parts/numberentry.xslt.
  • add the option to the editor.
@KookyLukey

This comment has been minimized.

Copy link

commented Feb 21, 2018

Hey, I would like to have a go at this one. I think I have a pretty good idea of what to do from your description. This will be my first time actually contributing to something open source, but seems like a cool project and good way to start being a regular contributor.

@christianp

This comment has been minimized.

Copy link
Member Author

commented Feb 21, 2018

@KookyLukey thanks for offering! Submit a pull request as soon as you've got something.

@paplio

This comment has been minimized.

Copy link

commented Feb 5, 2019

Hi! I noticed this is still open. Is there any chance I can get to work on it?

@christianp

This comment has been minimized.

Copy link
Member Author

commented Feb 5, 2019

@paplio thanks for offering! Have a look at our guidelines on contributing to Numbas and submit a pull request as soon as you've got something. Let me know if you have any trouble.

christianp added a commit to numbas/editor that referenced this issue Feb 20, 2019

christianp added a commit to numbas/editor-docs that referenced this issue Feb 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.