Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number entry part with precision should round correct answer to same precision as student used #553

Closed
christianp opened this issue Jun 21, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@christianp
Copy link
Member

commented Jun 21, 2018

An example given by Matt Funnell:

  • correct answer is 1.27. Student asked to give answer to 1 d.p., so 1.3 is marked correct.
  • If the student gives 1.27, the algorithm currently doesn't give partial marks for "right, but wrong precision" - the min/max values are rounded to the desired precision before comparing with student's answer.

Instead, the min/max should be rounded to the same level of precision as the student used (but at least the precision asked for, so the student can't just zequals the number and get partial marks). That tells you if the student had the right number, and then you can check if the number was given to the right precision.

christianp added a commit that referenced this issue Jun 21, 2018

numberentry: round min/max to same precision student used
see #553

Need to write some unit tests to check that this works as expected on
all combinations of precision type, desired precision, and student
precision.

@christianp christianp closed this Jun 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.