Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When already on the search page, the top search bar should remember the exams/questions settings #327

Closed
christianp opened this issue Sep 21, 2016 · 6 comments

Comments

Projects
None yet
3 participants
@christianp
Copy link
Member

commented Sep 21, 2016

When I type a new query into the search bar at the top of the page, the exams/questions filter should be preserved.
Maybe the other filters should be kept, too.

@christianp

This comment has been minimized.

Copy link
Member Author

commented Oct 3, 2016

To do this:

@gerlou

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2017

Hi Christian,

I'm starting to work on this issue. Just to clarify, is it the Questions and Exams check box under the "Show results for" bar on the left side of the page?

@christianp

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2017

@gerlou Yes, that's right,

@gerlou

This comment has been minimized.

Copy link
Contributor

commented Jul 13, 2017

I was working on the code and noticed that when I tried your suggestion, the filters weren't preserved when you pressed enter in the search bar. However, I could change the search button (the magnifying glass next to the search bar) to preserve the filters, but this won't work if the user presses the enter key. When the user presses enter to submit the form, the browser replaces the query string with only the query, and the filters aren't preserved. Do you have any other suggestions on how to fix this problem?

@christianp

This comment has been minimized.

Copy link
Member Author

commented Jul 13, 2017

The easiest way is always to make a pull request so I can see your code, and we can work from there.

@mjguru

This comment has been minimized.

Copy link
Contributor

commented Jul 26, 2018

I added hidden fields in the form for the search bar and I think it fixes the issue? The code is in the pull request #428.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.