Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display of sets in variable preview is sometimes too long #439

Closed
christianp opened this issue Nov 6, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@christianp
Copy link
Member

commented Nov 6, 2018

I have a feeling I've recently done the opposite of what I'm about to propose: when the string rendering of a set is too long, the preview should instead say something like "set of N items", similar to how lists are displayed.

@JoshuaCapel

This comment has been minimized.

Copy link
Contributor

commented Dec 17, 2018

I think I have resolved this with pull request: #443

@christianp

This comment has been minimized.

Copy link
Member Author

commented Dec 17, 2018

Thanks! I've merged it in.
For future reference: it makes my life easier if you create a separate branch for each pull request. That way, if you have more than one pull request open at once, I can merge them separately.

@JoshuaCapel

This comment has been minimized.

Copy link
Contributor

commented Dec 17, 2018

@christianp christianp closed this Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.