Skip to content

Commit 66c9d1e

Browse files
committed
cycles() only returns non-trivial cycles
Permutation.cycles() used to return 1-cycles, but I don't think those should count.
1 parent d4b775d commit 66c9d1e

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

‎permutations.js‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,9 @@ Numbas.addExtension('permutations',['jme','jme-display'],function(permutations)
124124
throw(new Numbas.Error("Not a cycle!"));
125125
}
126126
}
127-
cycles.push(cycle);
127+
if(cycle.length > 1) {
128+
cycles.push(cycle);
129+
}
128130
}
129131
}
130132
this._cycles = cycles;

0 commit comments

Comments
 (0)