Skip to content

Commit 5850bc6

Browse files
committed
fix the grade shown in the student progress view
A reused variable name meant that the wrong current score was shown for students who have a grade returned by the AGS.
1 parent 3c200c9 commit 5850bc6

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

numbas_lti/views/resource.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -275,9 +275,9 @@ def summarise_student(student):
275275
grades = [g for g in ags_grades if g['userId'] in subs]
276276
grade = grades[0] if grades else None
277277
if grade:
278-
score = grade.get('resultScore', 0)
279-
max_score = grade.get('resultMaximum', 0)
280-
reported_score = (score / max_score) if max_score > 0 else 0
278+
resultScore = grade.get('resultScore', 0)
279+
resultMaximum = grade.get('resultMaximum', 0)
280+
reported_score = (resultScore / resultMaximum) if resultMaximum > 0 else 0
281281
else:
282282
reported_score = 0
283283
score_not_reported = reported_score != score

0 commit comments

Comments
 (0)