Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output: fix for gcc 4.7 / c++11 destructor noexcept(true) #1432

Conversation

@breznak
Copy link
Member

commented Jul 30, 2018

https://stackoverflow.com/questions/42976461/exception-in-destructor-c
We locally allow throwing an exception from the ~Output destructor.

Fixes: #1000 #1414
Replaces: #1415

@breznak breznak requested a review from lscheinkman Jul 30, 2018

@lscheinkman

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2018

@breznak Could you take a look at https://ci.numenta.com/browse/NUP-NGPR-SC-469/log
I think you just need to fix the format. Just run the following command to fix it:

git clang-format upstream/master
@breznak

This comment has been minimized.

Copy link
Member Author

commented Jul 30, 2018

Sorry, somehow dupe of #1431

@breznak

This comment has been minimized.

Copy link
Member Author

commented Jul 30, 2018

Thanks @lscheinkman , formating done.

@lscheinkman
Copy link
Contributor

left a comment

👍 LGTM

@rhyolight rhyolight merged commit e0e4125 into numenta:master Aug 6, 2018

4 checks passed

Contributor Validator breznak signed the Contributor License
Details
ci/circleci: build-and-test Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/bamboo The build succeeded.
Details

@breznak breznak deleted the htm-community:community_fix_c++11_destructors_noexcept branch Aug 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.