Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build error on arm64 Linux #1440

Merged
merged 3 commits into from Jan 7, 2019

Conversation

@paulscode
Copy link
Contributor

commented Sep 9, 2018

This addresses issue #1439

@paulscode

This comment has been minimized.

Copy link
Contributor Author

commented Sep 12, 2018

Added a condition to CMakeLists.txt to avoid having to undefine NTA_ASM when building on arm64

@rhyolight

This comment has been minimized.

Copy link
Member

commented Sep 12, 2018

Both #1438 & #1440 introduce windows build errors, can you check them out?

@paulscode

This comment has been minimized.

Copy link
Contributor Author

commented Sep 12, 2018

Ok, will do. Off to set up a Windows build environment :)

@paulscode

This comment has been minimized.

Copy link
Contributor Author

commented Sep 12, 2018

@rhyolight I assume this is 64 bit Windows 10 (and not arm either), correct?

@rhyolight

This comment has been minimized.

Copy link
Member

commented Sep 12, 2018

@paulscode sorry see my comment on #1438

@rhyolight

This comment has been minimized.

Copy link
Member

commented Sep 26, 2018

@paulscode can you merge in master as soon as #1442 is merged? Then CI will run again with his changes.

@lscheinkman
Copy link
Contributor

left a comment

👍 LGTM

@rhyolight rhyolight merged commit 333290c into numenta:master Jan 7, 2019

3 of 4 checks passed

Contributor Validator paulscode must sign the Contributor License
Details
ci/circleci: build-and-test Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/bamboo The build succeeded.
Details
@rhyolight

This comment has been minimized.

Copy link
Member

commented Jan 7, 2019

Sorry this took so long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.