New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visualization event handlers to Connections class #933

Merged
merged 2 commits into from Jun 7, 2016

Conversation

Projects
None yet
4 participants
@mrcslws
Contributor

mrcslws commented Apr 26, 2016

Fixes #932

@numenta-ci

This comment has been minimized.

Show comment
Hide comment
@numenta-ci

numenta-ci Apr 26, 2016

By analyzing the blame information on this pull request, we identified @chetan51, @akhilaananthram and @rcrowder to be potential reviewers

numenta-ci commented Apr 26, 2016

By analyzing the blame information on this pull request, we identified @chetan51, @akhilaananthram and @rcrowder to be potential reviewers

@mrcslws

This comment has been minimized.

Show comment
Hide comment
@mrcslws

mrcslws Apr 26, 2016

Contributor

@scottpurdy

I verified that it [seems to be] performance-neutral.

Contributor

mrcslws commented Apr 26, 2016

@scottpurdy

I verified that it [seems to be] performance-neutral.

@rhyolight

This comment has been minimized.

Show comment
Hide comment
@rhyolight

rhyolight May 3, 2016

Member

@mrcslws merge in master

Member

rhyolight commented May 3, 2016

@mrcslws merge in master

@rhyolight

This comment has been minimized.

Show comment
Hide comment
@rhyolight
Member

rhyolight commented May 11, 2016

@mrcslws ping

return token;
}
void Connections::unsubscribe(UInt32 token)

This comment has been minimized.

@scottpurdy

scottpurdy May 12, 2016

Contributor

Would it be easier if subscribe took a char* name argument that you also pass to unsubscribe? That way the client just has to use the same string for both calls rather than keep track of the token returned.

@scottpurdy

scottpurdy May 12, 2016

Contributor

Would it be easier if subscribe took a char* name argument that you also pass to unsubscribe? That way the client just has to use the same string for both calls rather than keep track of the token returned.

This comment has been minimized.

@mrcslws

mrcslws May 12, 2016

Contributor

Fair point. But then:

  • This class would have to store copies of strings.
  • The caller would have to be careful not to use strings that are used elsewhere. When I grab HTM traces, I do it via a set of independent classes that are unaware of each other. It'd be easy for one of these classes to accidentally stomp on another class's event handler. To avoid this, each tracing class would have to generate a string and store it.

This "token" approach mimics javascript's setTimeout and setInterval API.

@mrcslws

mrcslws May 12, 2016

Contributor

Fair point. But then:

  • This class would have to store copies of strings.
  • The caller would have to be careful not to use strings that are used elsewhere. When I grab HTM traces, I do it via a set of independent classes that are unaware of each other. It'd be easy for one of these classes to accidentally stomp on another class's event handler. To avoid this, each tracing class would have to generate a string and store it.

This "token" approach mimics javascript's setTimeout and setInterval API.

@scottpurdy

This comment has been minimized.

Show comment
Hide comment
@scottpurdy

scottpurdy May 12, 2016

Contributor

Done with review. Looks like the SWIG directors are the right thing now that I looked into it more.

Contributor

scottpurdy commented May 12, 2016

Done with review. Looks like the SWIG directors are the right thing now that I looked into it more.

@numenta-ci

This comment has been minimized.

Show comment
Hide comment
@numenta-ci

numenta-ci Jun 7, 2016

WARNING! This Pull Request has been inactive for 25 days, and will be automatically closed in 5 days if not updated before then. This is an automated message.

numenta-ci commented Jun 7, 2016

WARNING! This Pull Request has been inactive for 25 days, and will be automatically closed in 5 days if not updated before then. This is an automated message.

@scottpurdy scottpurdy merged commit d2bc9de into numenta:master Jun 7, 2016

4 checks passed

Contributor Validator mrcslws signed the Contributor License
Details
Fixes Issue Validator PR is properly linked to an issue
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment