Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONTRIBUTING and RELEASE updates #39

Open
wants to merge 15 commits into
base: master
from

Conversation

@rhyolight
Copy link
Member

commented Aug 26, 2019

The process in RELEASE.md is not implemented. We will discuss this Wednesday at Numenta HQ.

CONTRIBUTING.md Outdated Show resolved Hide resolved
rhyolight added 2 commits Aug 27, 2019
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
rhyolight added 3 commits Aug 27, 2019
@lscheinkman
Copy link
Contributor

left a comment

👍 LGTM

@rhyolight

This comment has been minimized.

Copy link
Member Author

commented Aug 27, 2019

We'll do a team review tomorrow. Thanks for your help up front.

rhyolight added 3 commits Aug 29, 2019

- Update version available via `nupic.torch.__version__`
- `git tag $VERSION`
- `git push --tags upstream`

This comment has been minimized.

Copy link
@lscheinkman

lscheinkman Aug 30, 2019

Contributor

Dont forget to create a github release


workflows:
version: 2

validate-build-test:
validate-build-test-deploy:

This comment has been minimized.

Copy link
@lscheinkman

lscheinkman Aug 30, 2019

Contributor

If you change the job name then you need to update github branch protection rules: See https://github.com/numenta/nupic.torch/settings/branch_protection_rules/5520686
I recommend not changing the name if possible.

This comment has been minimized.

Copy link
@rhyolight

rhyolight Sep 18, 2019

Author Member

this may be my whole problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.