Skip to content
This repository has been archived by the owner on Sep 1, 2023. It is now read-only.

Create a mechanism to update the nupic.core dependency from nupic with every push to nupic.core master #590

Closed
rhyolight opened this issue Jan 29, 2014 · 8 comments

Comments

@rhyolight
Copy link
Member

Depends on #588, #589.

When the master branch is pushed to in nupic.core, the nupic project must rebuild with the latest source code from nupic.core. Essentially, any push to nupic.core master should trigger a fresh dependency link from nupic --> nupic.core, which should also trigger a new build of Travis-CI.

@rhyolight
Copy link
Member Author

I'm backtracking on this. We don't want nupic to build of nupic.core's master branch by default. There needs to be a manual conversion to a new commit SHA.

@rhyolight
Copy link
Member Author

I don't think we want this. The switch to another version of nupic.core will be a manual push.

@breznak
Copy link
Member

breznak commented Feb 4, 2014

really we don't want the above-described behavior? Lot of the tests/apps
are in python, so I thought each change to core should be validated with
the "nupic ecosystem" in nupic repo?

@rhyolight
Copy link
Member Author

Perhaps validated, but I wouldn't want nupic to auto-switch to using the
latest tip of nupic.core's master branch. Maybe I could make a travis build
that runs nupic against the nupic.core master on every push just for
validation.


Matt Taylor
OS Community Flag-Bearer
Numenta

On Tue, Feb 4, 2014 at 3:09 PM, breznak notifications@github.com wrote:

really we don't want the above-described behavior? Lot of the tests/apps
are in python, so I thought each change to core should be validated with
the "nupic ecosystem" in nupic repo?

Reply to this email directly or view it on GitHubhttps://github.com//issues/590#issuecomment-34119217
.

@utensil
Copy link
Member

utensil commented Apr 3, 2014

@rhyolight commented 2 months ago

Maybe I could make a travis build that runs nupic against the nupic.core master on every push just for validation.

Is there any updates on this? Observing numenta/nupic.core-legacy#47 and #751, I propose a special travis build for nupic.core, basically it:

  1. clones numenta/nupic@HEAD
  2. updates submodule SHA1 refernece to numenta/nupic.core@HEAD but does NOT commit
  3. runs travis on it

I can think of some difficulties, such as:

  1. since it's a a special travis build for nupic.core, not for nupic, something needs to be done to simulate a travis run under nupic.core with DRY in mind .
  2. needs to validate pull requests too, so the submodule needs to be changed to a local merged version of nupic.core or something like that .

It could be the other way around, a special build triggered by a nupic.core commit, difficulty 1 would be solved this way, but difficulty 2 would become impossible to solve IMO.

@rhyolight
Copy link
Member Author

Thanks for your thoughts @utensil. I will think about this today.

@rhyolight
Copy link
Member Author

I would be comfortable having nupic automatically point to nupic.core@master after we've released nupic.core. So I will reopen this ticket and put on backlog.

@rhyolight rhyolight reopened this Apr 4, 2014
@rhyolight rhyolight removed this from the Sprint 15 milestone Apr 4, 2014
@utensil
Copy link
Member

utensil commented Jun 21, 2014

Should now be closed by numenta/nupic.tools#62 .

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants