Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Missing and unsynchronized SVGs #508
Comments
Sakrecoer
changed the title from
Missing and unsyncronized SVGs
to
Missing and unsynchronized SVGs
Aug 8, 2016
|
@khurshid-alam I actually have a |
|
@satya164 Cool. Thanks. |
|
Thank you for your quick respone @satya164 and @khurshid-alam ! Looking forward to those assets! Thank you for your time and consideration! Yours, |
|
Hi guys! Not too sure when tonight is under your latitudes, and i don't mean to be nagging. Just thought i'd poke the issue :) Hope you don't mind... Thankful regards, |
|
Sorry. Seems @khurshid-alam forgot to ping me. Here is the zip with SVGs |
|
Ah. Sorry. Completely forgot about that. But it seems there is some sort download problem. |
khurshid-alam
closed this
Aug 14, 2016
|
Seems the download works fine here! Thank you guys, means a lot for us!! |
khurshid-alam
reopened this
Aug 26, 2016
khurshid-alam
added
bug
help welcomed
labels
Aug 26, 2016
|
We can not use new assets svgs yet. Because of this-> #528 (comment) |
|
thank you @khurshid-alam ! I noticed it, but haven't got the time to report it yet. Sorry for that. Thank you for looking into this! |
|
@khurshid-alam When I open the SVGs in browser they all have borders. I think there is issue with SVG format exported from Sketch. I'm attaching the file as PDF here from which someone should be able to take the vectors out in Inkscape. I've also exported them to EPS if it makes the conversion easier. |
|
thank you @satya164 ! Awesome! I might as well do that during this week. Will submit a pull request whenever i'm done :) |
|
@satya164 I also thought they (svgs) were not properly exported. Thanks for EPS. :) |
|
Just fyi, I saved links to the assets for future reference in the wiki |
|
@satya164 may i ask where the EPS are? maybe i missed something but, the zip you link in this reply contains SVGs ps. @lots0logs i tried the wiki link and the zip listed there also contains SVGs, instead of EPS as stated on the link |
|
@Sakrecoer Oops. Seems I uploaded the wrong file. Uploading the correct one now. Thanks. |
|
@Sakrecoer Check now. |
|
@satya164 Thank you!! \o/ |
|
@Sakrecoer BTW not sure if EPS can handle gradients and stuff. So probably editing the PDF is the best bet. |
|
If it's not possible to extract out proper SVGs, let me know and I'll try exporting them from Affinity Designer which has better SVG support. |
|
@satya164 yes, i just saw that... was wondering if it was because of inkscape's interpretation of EPS. If you have some spare time to try with Affinity Designer, please do. Otherwise, all good, it should be fine with the PDF, just more manual work |
|
@Sakrecoer I can do that over the weekend since it'll be manual work of exporting each item one by one. |
|
@satya164 ok, if it is manual work for you too, then i propose you relax until i submit mine sometime before next Friday. Would i have made lots of mistakes or done it wrong, I'll leave it up to you, fair deal? :) |
|
@Sakrecoer Sounds good :D |
|
What'll be cool is, if we can keep all SVGs in one file and export them to multiple files. This is not very simple with Inkscape, but once setup, should be good to go. |
|
I suppose that would require a file with defined grid. I am afraid i don't have the skills to do the scripting required afterwards. However, I noticed some of the assets are 32x32 (grid-selected-*) while the rest is 16x16. If this distinction is necessary, can we still have them in the same file? |
|
@Sakrecoer Yeah, we need those at different size. Exporting shouldn't be very hard. http://typethinker.blogspot.in/2010/07/exporting-slices-from-inkscape.html |
|
looking into it now. I'm still missing an asset for |
|
looking at the new PNGs, I'll use that one :) |
|
Here you go: #549 Note that i didn't touch the PNGs that were in your master. I tested the script and the result though, and it worked like a charm! |
Sakrecoer commentedAug 8, 2016
•
Edited 1 time
-
Sakrecoer
Aug 8, 2016
Hi,
Over at Ubuntu Studio, we are looking into customizing the colors of this fantastic theme to our color-scheme, and while doing so, i noticed that the SVGs aren't synchronized with the PNGs. That is; the source SVG-files have a completly different look from the PNG-files used by https://github.com/numixproject/numix-gtk-theme/blob/master/gtk-3.0/gtk.gresource.xml
Also, some PNGs are missing their SVG counter-part such as: https://github.com/numixproject/numix-gtk-theme/blob/master/gtk-3.0/assets/radio-checked.png
I went through all the SVGs and synced them as good as I could to the current PNGs, also I managed to recreate the missing SVGs without major trouble, but they are not 100% similar; i lack the perfect tiny little shade of red in the bottom of the radio-buttons and the checkboxes .
Would you be so kind as to provide the source SVGs? If they have gone lost, would you be interested in a Pull Request from me with my replicas?
Regardless, i also want to thank you for your awesome work! :)
Yours,
*Sakrecoer