Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with librsvg-2.52.0 #1405

Closed
pillmuncher opened this issue Sep 23, 2021 · 9 comments
Closed

Problem with librsvg-2.52.0 #1405

pillmuncher opened this issue Sep 23, 2021 · 9 comments
Labels

Comments

@pillmuncher
Copy link

pillmuncher commented Sep 23, 2021

After the weekly update of Solus Linux yesterday the User Indicator icon (Numix/scalable/actions/system-shutdown-symbolic.svg) had disappeared both from the Budgie Panel, as well as the LightDM login screen, yet not from the file system. It has since been determined that a downgrade from librsvg-2.52.0 to librsvg-2.50.7 fixes the problem. Thought y'all oughta know.

See also:
https://discuss.getsol.us/d/7442-user-indicator-icon-missing/7
https://dev.getsol.us/T9920

@palob palob added the bug label Sep 23, 2021
@palob
Copy link
Member

palob commented Sep 23, 2021

I can confirm this. I don't see a shutdown icon in GNOME on Arch but I didn't notice so far, maybe I took it for a design choice.

@Foggalong
Copy link
Contributor

That's really weird, especially that the presence of the numix-icon-theme package is causing issues for other themes

@algent-al
Copy link

That's really weird, especially that the presence of the numix-icon-theme package is causing issues for other themes

I think the reason for that is because the affected icon themes are inhering icons from Numix.
For example you can see Surfn index.theme:
https://github.com/erikdubois/Surfn/blob/master/surfn-icons/Surfn/index.theme#L4

@Foggalong
Copy link
Contributor

That's useful intel, thanks Algent!

@Noobsai
Copy link

Noobsai commented Sep 24, 2021

I defined the width property in the svg file and problem is gone
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16.0243" width="16" height="16.02">

@Foggalong
Copy link
Contributor

Foggalong commented Sep 24, 2021

In which case this is almost certainly a bug with librsvg 2.52, not numix-icon-theme; the height and width attributes are optional in the SVG spec (default 100%, with us controlling size via viewbox).

We could add a width attribute to any SVG file missing them to work around the problem, but that should only be a temporary fix until librsvg fixes whatever the problem is on their end.

@pillmuncher
Copy link
Author

I opened an issue at GNOME's gitlab: https://gitlab.gnome.org/GNOME/librsvg/-/issues/797

@Foggalong
Copy link
Contributor

Foggalong commented Sep 26, 2021

Thanks @pillmuncher, will tack this issue there for now! I just did a quick check and there are over 20,000 SVG files across our main themes which don't have a width attribute 😰

@Foggalong
Copy link
Contributor

Upstream bug has now been fixed, pegged for release in 2.52.1 pending a fix for another unrelated bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

5 participants