From d248107e72a123892196cf548f197d43b629f34e Mon Sep 17 00:00:00 2001 From: Nathan Goldbaum Date: Fri, 3 Mar 2023 10:06:50 -0700 Subject: [PATCH] Fix memory leak in _memory_usage --- stringdtype/stringdtype/src/dtype.c | 2 -- stringdtype/stringdtype/src/main.c | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/stringdtype/stringdtype/src/dtype.c b/stringdtype/stringdtype/src/dtype.c index 44fc328d..c8e8db4b 100644 --- a/stringdtype/stringdtype/src/dtype.c +++ b/stringdtype/stringdtype/src/dtype.c @@ -246,8 +246,6 @@ stringdtype_new(PyTypeObject *NPY_UNUSED(cls), PyObject *args, PyObject *kwds) static void stringdtype_dealloc(StringDTypeObject *self) { - // Need to deallocate all the memory allocated during setitem. - PyArrayDescr_Type.tp_dealloc((PyObject *)self); } diff --git a/stringdtype/stringdtype/src/main.c b/stringdtype/stringdtype/src/main.c index f5691bb0..64797492 100644 --- a/stringdtype/stringdtype/src/main.c +++ b/stringdtype/stringdtype/src/main.c @@ -64,6 +64,8 @@ _memory_usage(PyObject *NPY_UNUSED(self), PyObject *obj) } while (iternext(iter)); + NpyIter_Deallocate(iter); + PyObject *ret = PyLong_FromSize_t(memory_usage); return ret;