Skip to content

Commit

Permalink
18532: Fix the numpy Apple M1 build.
Browse files Browse the repository at this point in the history
There was a build issue on numpy with M1:
AssertionError: would build wheel with unsupported tag ('cp39', 'cp39', 'macosx_11_0_universal2')

The issue was fixed in the packaging 20.5 and onwards, but that was not
getting picked by setuptools. So explicitly adding this dependency in
the toml file. The change was tested with:

```
python3 -m pip install --force-reinstall .
```
  • Loading branch information
kulinseth committed Mar 3, 2021
1 parent f691b02 commit 0a8dca0
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions pyproject.toml
@@ -1,6 +1,7 @@
[build-system]
# Minimum requirements for the build system to execute.
requires = [
"packaging==20.5",
"setuptools<49.2.0",
"wheel==0.36.2",
"Cython>=0.29.21,<3.0", # Note: keep in sync with tools/cythonize.py
Expand Down

2 comments on commit 0a8dca0

@gzz2000
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This allows me to build numpy on M1.

@ztnel
Copy link

@ztnel ztnel commented on 0a8dca0 May 7, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a legend

Please sign in to comment.