Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickstart guide recommends np.set_printoptions(threshold=np.nan), which fails #13900

Closed
eric-wieser opened this issue Jul 3, 2019 · 3 comments · Fixed by #13948
Closed

Quickstart guide recommends np.set_printoptions(threshold=np.nan), which fails #13900

eric-wieser opened this issue Jul 3, 2019 · 3 comments · Fixed by #13948

Comments

@eric-wieser
Copy link
Member

We should update this guide to use sys.maxsize.

@mattip, I'm correct in assuming you prefer that to np.inf?

@mattip
Copy link
Member

mattip commented Jul 3, 2019

yes, and it should be mentioned as the preferred max value in the docstring as well

@sameshl
Copy link
Contributor

sameshl commented Jul 9, 2019

@mattip Can you help me figure out why the tests on my PR are failing, I have just updated the documentation and docstrings.

@sameshl
Copy link
Contributor

sameshl commented Jul 9, 2019

@mattip Can you review my PR #13948

seberg pushed a commit that referenced this issue Jul 9, 2019
… (#13948)

Quickstart guide recommends np.set_printoptions(threshold=np.nan) but that fails.
So changed that to np.set_printoptions(threshold=sys.maxsize)

Closes #13900

* DOC:Update the docstring of set_printoptions

Add preferred max value for threshold is sys.maxsize

* Revert "DOC:Update the docstring of set_printoptions"

This reverts commit 9641121.

* DOC:Update the docstring of set_printoptions

Add preferred max value for threshold is sys.maxsize

* DOC:Update the docstring of set_printoptions

Better pharasing in docstring.

* DOC:Update the description of set_printoptions in quickstart doc #13900

Fix indentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants