Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

DOC: Use tp_basicsize, not NPY_SIZEOF_PYARRAYOBJECT, for allocation #2980

Closed
bfroehle opened this Issue Feb 12, 2013 · 2 comments

Comments

Projects
None yet
3 participants
Contributor

bfroehle commented Feb 12, 2013

As @charris mentioned in #2975, we should mention the NPY_SIZEOF_PYARRAYOBJECT -> type->tp_basicsize change in doc/release/1.8.0-notes.rst.

Does this look okay? I'll create a pull request when we have agreed upon language.

The ``PyArray_Type`` instance creation function ``tp_new`` now
uses ``tp_basicsize`` to determine how much memory to allocate.
In previous releases only ``sizeof(PyArrayObject)`` bytes of
memory were allocated, often requiring C-API subtypes to
reimplement ``tp_new``.
Owner

njsmith commented Feb 12, 2013

Looks fine to me.
On 12 Feb 2013 13:18, "Bradley M. Froehle" notifications@github.com wrote:

As @charris https://github.com/charris mentioned in #2975#2975,
we should mention the NPY_SIZEOF_PYARRAYOBJECT -> type->tp_basicsizechange in
doc/release/1.8.0-notes.rst.

Does this look okay? I'll create a pull request when we have agreed upon
language.

The PyArray_Type instance creation function tp_new now
uses tp_basicsize to determine how much memory to allocate.
In previous releases only sizeof(PyArrayObject) bytes of
memory were allocated, often requiring C-API subtypes to
reimplement tp_new.


Reply to this email directly or view it on GitHubhttps://github.com/numpy/numpy/issues/2980.

Owner

charris commented Feb 21, 2014

@bfroehle Looks like this never made it in... It's never to late to update the release notes.

bfroehle added a commit to bfroehle/numpy that referenced this issue Mar 1, 2014

DOC: Use tp_basicsize, not NPY_SIZEOF_PYARRAYOBJECT, for allocation
As mentioned in #2975, add agreed upon text from #2980 to the release notes.

Closes #2980.

bfroehle added a commit to bfroehle/numpy that referenced this issue Mar 1, 2014

DOC: Use tp_basicsize, not NPY_SIZEOF_PYARRAYOBJECT, for allocation
As mentioned in #2975, add agreed upon text from #2980 to the release notes.

Closes #2980.

@bfroehle bfroehle closed this May 20, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment