Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

make sure there aren't any deprecation warnings that incorrectly say stuff will happen in 1.8 #3228

Closed
njsmith opened this Issue Apr 11, 2013 · 4 comments

Comments

Projects
None yet
3 participants
Owner

njsmith commented Apr 11, 2013

There are a number of deprecations that we expected would be finalized in 1.8, but that won't be, e.g. gh-596, gh-456, gh-294. We've bumped them to reconsider for 1.9, but we should run a grep over the source to make sure that we haven't left any behind any messages that say "Warning: blah balh will happen in numpy 1.8", and if there are any we should replace them with something more vague.

Member

seberg commented Apr 11, 2013

Just did a quick grep. It seems that the only occasion that mentions either 1.8. or 1.9. together with deprecations is the diagonal documentation.

Owner

charris commented Aug 11, 2013

There is a test_diagonal_deprecation that checks for FutureWarning. I believe that warning was for 1.7 and we should be returning a ro view of the diagonal. Need to check that and remove the warning and test.

Owner

charris commented Aug 12, 2013

Here is the FutureWarning message

        "Numpy has detected that you (may be) writing to an array returned\n"
        "by numpy.diagonal or by selecting multiple fields in a record\n"
        "array. This code will likely break in the next numpy release --\n"
        "see numpy.diagonal or arrays.indexing reference docs for details.\n"
        "The quick fix is to make an explicit copy (e.g., do\n"
        "arr.diagonal().copy() or arr[['f0','f1']].copy()).";

What is the multiple fields thing?

Owner

charris commented Aug 12, 2013

See #3604 for the diagonal fixup.

charris added a commit to charris/numpy that referenced this issue Aug 12, 2013

DOC: Remove references to diagonal changes in 1.8.
Not happening. Also remove reference to selecting multiple fields out of
an array returning a view from 1.8.0 release notes.

Closes #3228.

@charris charris closed this in #3608 Aug 15, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment