Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numpy test fails with python3.7 - PyTraceMalloc_Untrack #9227

Closed
dwintergruen opened this issue Jun 8, 2017 · 9 comments
Closed

numpy test fails with python3.7 - PyTraceMalloc_Untrack #9227

dwintergruen opened this issue Jun 8, 2017 · 9 comments

Comments

@dwintergruen
Copy link

Trying to build numpy (master) with python3.7 (ubuntu 16.02, python from git)
Compiling seems to work, but the tests give

ImportError: FOO/numpy/build/testenv/lib/python3.7/site-packages/numpy/core/multiarray.cpython-37dm-x86_64-linux-gnu.so: undefined symbol: PyTraceMalloc_Untrack

Who can help?

@juliantaylor
Copy link
Contributor

it will work as soon as python/cpython#1236 is merged
until then you can change the required version number in the defines in alloc.c

@njsmith njsmith reopened this Jun 10, 2017
@njsmith
Copy link
Member

njsmith commented Jun 10, 2017

Well, I guess we're learning something here... Someone else just ran into this and filed a bug upstream with python: http://bugs.python.org/issue30623

1.13 came out 3 days ago, and we've already had 2 reports, one misdirected. To me that means we need to fix this. Apparently people actually test python master these days. (At least @brettcannon will be pleased :-))

Untangling ourselves is a bit complicated though. The worst would be if we scramble to release a 1.13.1 that switches to unconditionally using the underscore-prefixed version, and simultaneously cpython scrambles to merge that PR to drop the underscore, and then we're back where we started.

I guess the most robust option would be to add a build time check for the symbol. But if that's annoying or will delay releasing a bug fix, then we should switch back to the underscore version unconditionally. And in any case I'll nudge Victor about making that PR provide a backcompat #define and perhaps getting merged sooner than later.

@charris charris added this to the 1.13.1 release milestone Jun 10, 2017
@charris
Copy link
Member

charris commented Jun 10, 2017

I note that 1.13 does not officially support Python 3.7, much less its development version. But I suppose it won't hurt to check if the function is present. I don't think we have checked the Python C-API before...

@juliantaylor
Copy link
Contributor

I didn't expect cpython to be so slow in merging, pinging them should be enough.

@tacaswell
Copy link
Contributor

Also seeing this in the Matplotlib tests (and finally getting around to tracking it down...)

@charris
Copy link
Member

charris commented Jun 16, 2017

pinging them should be enough.

Guess again ;)

@charris
Copy link
Member

charris commented Jun 18, 2017

Removing the 1.13.1 milestone. If there is still a problem when Python 3.7 is released we will deal with it then.

@charris charris removed this from the 1.13.1 release milestone Jun 18, 2017
@tacaswell
Copy link
Contributor

python/cpython#1236 has been merged, I think this and the cpython bug can be closed?

matplotlib nightly is working again on travis :)

@charris
Copy link
Member

charris commented Jun 24, 2017

@tacaswell Thanks for the update.

@charris charris closed this as completed Jun 24, 2017
@eric-wieser eric-wieser changed the title bumpy test fails with python3.7 - PyTraceMalloc_Untrack numpy test fails with python3.7 - PyTraceMalloc_Untrack Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants