Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fix einsum issue with unicode input and py2 #10396

Merged
merged 1 commit into from Jan 14, 2018

Conversation

Projects
None yet
2 participants
@charris
Copy link
Member

commented Jan 14, 2018

Backport of #10371, fixes #10369.

The issue was the use of isinstance(..., str). There is a np.compat.basestring but I used the way that is used in np.core to re-define basestring for py3.

@charris charris merged commit 0147728 into numpy:maintenance/1.14.x Jan 14, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: Python No alert changes
Details

@charris charris deleted the charris:backport-90371 branch Jan 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.