Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Set einsum optimize parameter default to `False`. #10403

Merged
merged 1 commit into from Jan 14, 2018

Conversation

Projects
None yet
1 participant
@charris
Copy link
Member

commented Jan 14, 2018

There have been bugs reported with einsum with the optimize=True
default, see #10343. This PR makes the default False for the 1.14.1
release. Because optimizing the contractions is not a trivial problem,
this will allow us to pursue fixes in the longer time frame of the 1.15
release.

BUG: Make the einsum optimize default to `False`.
There have been bugs reported with einsum with the `optimize=True`
default, see #10343. This PR makes the default `False` for the 1.14.1
release. Because optimizing the contractions is not a trivial problem,
this will allow us to pursue fixes in the longer time frame of the 1.15
release.

@charris charris added this to the 1.14.1 release milestone Jan 14, 2018

@charris charris changed the title BUG: Make the einsum optimize default to `False`. BUG: Make einsum optimize parameter default to `False`. Jan 14, 2018

@charris charris changed the title BUG: Make einsum optimize parameter default to `False`. BUG: Make einsum optimize parameter default `False`. Jan 14, 2018

@charris charris changed the title BUG: Make einsum optimize parameter default `False`. BUG: Set einsum optimize parameter default to `False`. Jan 14, 2018

@charris charris merged commit 635e61c into numpy:maintenance/1.14.x Jan 14, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: Python No alert changes
Details

@charris charris deleted the charris:change-optimize-default branch Jan 14, 2018

dhirschfeld referenced this pull request in HIPS/autograd Feb 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.