Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Use ValueError for duplicate field names in lookup (backport) #10435

Merged

Conversation

Projects
None yet
2 participants
@eric-wieser
Copy link
Member

commented Jan 18, 2018

Also contains #10418, because in practice we're going to want the same baseline on master and 1.14 to fix the regressions on top of.

Backports #10430

eric-wieser added some commits Jan 17, 2018

MAINT: Use ValueError for duplicate field names in lookup
KeyError suggests the field name does not exist, which is inaccurate.

@charris charris added this to the 1.14.1 release milestone Jan 18, 2018

@charris charris merged commit 656c191 into numpy:maintenance/1.14.x Jan 18, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: Python No alert changes
Details
@charris

This comment has been minimized.

Copy link
Member

commented Jan 18, 2018

Thanks Eric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.