Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: multifield-indexing adds padding bytes: revert for 1.14.1 #10537

Merged

Conversation

Projects
None yet
2 participants
@ahaldane
Copy link
Member

commented Feb 7, 2018

Fixes #10387
Fixes #10344
Fixes #10409

This is a version of #10411 targeting the 1.14.x maintenance branch. It reverts the copy->view change from 1.14.0, aiming to get into 1.14.1.

_multifield_view_to_copy(PyArrayObject **view) {
static PyObject *copyfunc = NULL;
PyObject *viewcopy;
PyObject *mf_setting = NULL;

This comment has been minimized.

Copy link
@charris

charris Feb 7, 2018

Member

Seems this variable is no longer used, leading to test errors.

@charris charris added this to the 1.14.1 release milestone Feb 7, 2018

@ahaldane ahaldane force-pushed the ahaldane:revert_multifield_view_1.14 branch from 18d08ca to ab349d7 Feb 7, 2018

@ahaldane ahaldane force-pushed the ahaldane:revert_multifield_view_1.14 branch from ab349d7 to 08469bb Feb 7, 2018

@charris charris merged commit 7e980b5 into numpy:maintenance/1.14.x Feb 7, 2018

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: Python No alert changes
Details
@charris

This comment has been minimized.

Copy link
Member

commented Feb 7, 2018

Thanks Allan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.