Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Add missing DECREF in Py2 int() cast #10540

Merged
merged 1 commit into from Feb 7, 2018

Conversation

Projects
None yet
2 participants
@charris
Copy link
Member

commented Feb 7, 2018

The Long number is downcast to int if possible, so the old version
has to be DECREF'ed.

Thanks to Johannes Barthelmes for bisecting the offending commit.

Closes gh-10474

Backport of gh-10482

BUG: Add missing DECREF in Py2 int() cast
The Long number is downcast to int if possible, so the old version
has to be DECREF'ed.

Thanks to Johannes Barthelmes for bisecting the offending commit.

Closes gh-10474

@charris charris added this to the 1.14.1 release milestone Feb 7, 2018

@charris charris merged commit bc66fbc into numpy:maintenance/1.14.x Feb 7, 2018

3 of 4 checks passed

ci/circleci Your tests failed on CircleCI
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: Python No alert changes
Details

@charris charris deleted the charris:backport-10482 branch Feb 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.