Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: Issue FutureWarning when malformed records detected. #10558

Merged
merged 1 commit into from Feb 9, 2018

Conversation

Projects
None yet
2 participants
@charris
Copy link
Member

commented Feb 9, 2018

Backport of #10543.

Currently records specified as lists of lists instead of lists of tuples
are caught and fixed up in fromrecords. Unfortunately, the detection is
failing due to various fixes in the records module. The failure is
worked around by generalizing the detection. A FutureWarning that such
record specifications will result in an error in the future is also
emitted.

Fixes #10344.

DEP: Issue FutureWarning when malformed records detected.
Currently records specified as lists of lists instead of lists of tuples
are caught and fixed up in fromrecords. Unfortunately, the detection is
failing due to various fixes in the records module. The failure is
worked around by generalizing the detection. A FutureWarning that such
record specifications will result in an error in the future is also
emitted.

Fixes #10344.

@charris charris added this to the 1.14.1 release milestone Feb 9, 2018

@ahaldane

This comment has been minimized.

Copy link
Member

commented Feb 9, 2018

Note this is a backport of #10543

Merging, thanks Chuck!

@ahaldane ahaldane merged commit 775e54d into numpy:maintenance/1.14.x Feb 9, 2018

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: Python No alert changes
Details

@charris charris deleted the charris:warn-malformed-data branch Feb 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.