Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix einsum optimize logic for singleton dimensions #10559

Merged
merged 4 commits into from Feb 9, 2018

Conversation

Projects
None yet
3 participants
@charris
Copy link
Member

commented Feb 9, 2018

Backport of #10352.

Closes #10343.

I don't know if it's the correct fix because these functions have a lot of logic going on that I have never looked at before (and haven't looked at too closely). Feel free to close if the right solution is a bit more involved.

@charris charris added this to the 1.14.1 release milestone Feb 9, 2018

@charris charris merged commit 3f82455 into numpy:maintenance/1.14.x Feb 9, 2018

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: Python No alert changes
Details

@charris charris deleted the charris:backport-10352 branch Feb 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.