Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Revert sort optimization in np.unique. #10608

Merged
merged 1 commit into from Feb 17, 2018

Conversation

Projects
None yet
1 participant
@charris
Copy link
Member

commented Feb 16, 2018

Backport of #10588.

The optimization was to sort integer subarrays by treating them as
strings of unsigned bytes. That worked fine for finding the unique
subarrays, but the sort order of the results could be unexpected.

Closes #10495.

@charris charris added this to the 1.14.1 release milestone Feb 16, 2018

BUG: Revert sort optimization in np.unique.
Backport of #10588.

The optimization was to sort integer subarrays by treating them as
strings of unsigned bytes. That worked fine for finding the unique
subarrays, but the sort order of the results could be unexpected.

Closes #10495.

@charris charris force-pushed the charris:backport-10588 branch from 97bdba9 to c9d4e6e Feb 16, 2018

@charris charris merged commit a35a040 into numpy:maintenance/1.14.x Feb 17, 2018

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: Python No alert changes
Details

@charris charris deleted the charris:backport-10588 branch Sep 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.