Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: deallocate recursive closure in arrayprint.py (1.14 backport) #10622

Conversation

Projects
None yet
3 participants
@ahaldane
Copy link
Member

commented Feb 17, 2018

Fixes #10620
Backport of #10621

@ahaldane ahaldane force-pushed the ahaldane:fix_arrayprint_recursive_closure_backport branch from bdb79d2 to 92c23cf Feb 17, 2018

@charris

This comment has been minimized.

Copy link
Member

commented Feb 18, 2018

I'm going to rely on the tests here and put this in for 1.14.

@charris charris merged commit d0ba54f into numpy:maintenance/1.14.x Feb 18, 2018

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
lgtm analysis: Python No alert changes
Details
@charris

This comment has been minimized.

Copy link
Member

commented Feb 18, 2018

Thanks Allan.

@charris charris added this to the 1.14.1 release milestone Feb 18, 2018

@eric-wieser

This comment has been minimized.

Copy link
Member

commented Feb 19, 2018

Do we want to revert this and apply the updated #10620?

@charris

This comment has been minimized.

Copy link
Member

commented Feb 19, 2018

I'm happy to go either way. If the updated version is available and better, go ahead and backport it. If it doesn't differ much, just branch off 1.14 and check it out of master and commit, that works better than cherry-picking when the merge isn't clean and is nicer than a reversion (IMHO).

@ahaldane

This comment has been minimized.

Copy link
Member Author

commented Feb 19, 2018

It looks easier to me to do revert + cherry-pick, because of the messy diff in _formatArray combined with other changes in that file in master.

I think it would be nice to put in the updated patch. I'll wait until we merge that one, and then I'll submit the packport.

ahaldane added a commit to ahaldane/numpy that referenced this pull request Feb 19, 2018

Revert "Merge pull request numpy#10622 from ahaldane/fix_arrayprint_r…
…ecursive_closure_backport"

This reverts commit d0ba54f, reversing
changes made to eaac472.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.